benjaminkott / benjaminkott/syntax

Is it a good idea to always add your CKEditor plugin?

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

> This issue is regarding the event listener, which modifies every CKEditor preset. https://github.com/benjaminkott/syntax/blob/979354c52e199b165570939d776256cfb9d6c908/Classes/EventListener/RteConfigEnhancer.php#L29

To my understanding we have the nice possibility to create many CKEditor presets where you can explicitly fine grade what you need. I often have multiple presets with complete different use cases and very different configs to support the backend editor as much as it is possible. With your approach the adoptions are made ALWAYS, no matter how the preset is configured. This often makes sense in smaller TYPO3 projects, but not for enterprise.

So, what do you think about adding at least an extension configuration setting which can be used to disable the default injection of your extension related CKEditor preset adoptions?

I really would like to discuss this on your implementation. Let's find some way to have an example implementation of the used event listener. We can add examples in the rte_ckeditor documentation afterwards too.

@benjaminkott, what are your backgrounds to the currently implemented approach?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.