benjaminkott / benjaminkott/bootstrap_package
Cookie consent type "opt-in" and event dispatching
- Dominant language
- PHP
- Stars
- 355
- Forks
- 212
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 31
Description
Hello,
In `bootstrap.cookieconsent.js`, on cookieConsent event `onPopupOpen`, you're dispatching the event `bk2k.cookie.enable` if type is "info" or "opt-out".
That is ok, because cookies should be enabled for those types of consent, as long as the user didn't express his consent.
But shouldn't you also dispatch the event `bk2k.cookie.disable` if type is "opt-in"?
If i'm not mistaken, "opt-in" means cookies should be disabled as long as the user didn't express his consent. That will disable analytics tracking as long as the user didn't click to allow cookies, which is GDPR compliant.
Thanks for reading :)
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.