benjaminkott / benjaminkott/bootstrap_package

Wrong icon size after changing the constants

Open
#756 2 comments 0 reactions 0 assignees View on GitHub
bug feature
Dominant language
PHP
Stars
355
Forks
212
Avg merge
1h 4m
Merged PRs (30d)
31

Description

# Bug Report
The icon in a medium size content element texticon don't resize to a larger value if the constant is changed from default to 60.
plugin.bootstrap_package_contentelements.texticon.icon.medium.height = 60
plugin.bootstrap_package_contentelements.texticon.icon.medium.width = 60

## Prerequisites

* [ ] Can you reproduce the problem on TYPO3 v8.7 LTS
* [x] Can you reproduce the problem on TYPO3 v9.5 LTS
* [x] Did you [perform a cursory search](https://github.com/issues?q=is%3Aissue+user%3Abenjaminkott+repo%3Abenjaminkott%2Fbootstrap_package) to see if your bug or enhancement is already reported?

## Description
If for example the constant plugin.bootstrap_package_contentelements.texticon.icon.medium.height and plugin.bootstrap_package_contentelements.texticon.icon.medium.width is changed to 60 the icon doesnt appear bigger in the frontend even if the img size is 60x60. It stays small (48x48px).

## Steps to Reproduce
1. Change plugin.bootstrap_package_contentelements.texticon.icon.medium.height and plugin.bootstrap_package_contentelements.texticon.icon.medium.width to 60
2. Check the frontend
3. The icon size is 60x60 but the box is still 48x48

**Expected behavior:**
![texticon-size-3](https://user-images.githubusercontent.com/8898397/65959467-5bcb1d80-e452-11e9-9cd4-463fb4aed46a.JPG)

**Actual behavior:**
![texticon-size-1](https://user-images.githubusercontent.com/8898397/65959375-1ad30900-e452-11e9-8367-898ed78ddc13.JPG)
![texticon-size-2](https://user-images.githubusercontent.com/8898397/65959376-1b6b9f80-e452-11e9-87f8-3576a49927ac.JPG)

## Versions
TYPO3 9.5.9 - Bootstrap Package 11.0.1

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue on TYPO3 9.5.9 with Bootstrap Package 11.0.1 using the texticon content element and the two medium icon constants set to 60. Trace the frontend rendering and sizing of the icon; done means the image and its surrounding box both render at 60x60 instead of remaining 48x48.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, php
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.