benjaminkott / benjaminkott/bootstrap_package

Audio files are not rendered properly

Open Beginner friendly
#1,633 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
355
Forks
212
Avg merge
1h 4m
Merged PRs (30d)
31

Description

# Bug Report

Audio files such as MP3s are not rendered properly.

## Description

Rendering will output something like this.

```html





```

Note that there is no `controls` attribute, only `controlslist`. But this seems to be necessary, such that Chrome (presumable Edge) and Firefox will not hide this element.

## Steps to Reproduce

1. Place any audio element on any page.
2. Visit the page.

### Expected behavior

The audio element should be visible.

### Actual behavior

Element is not visible.

## Versions

- TYPO3 v13
- Latest compatible Bootstrap Package

## Solution

Add `additionalAttributes="{controls: true}"` to `Resources/Private/Partials/ContentElements/Media/Rendering/Audio.html`.

Contributor guide

No contributing guide indexed for this repository

Research direction

The affected template is Resources/Private/Partials/ContentElements/Media/Rendering/Audio.html; start by inspecting how the audio element is rendered and reproduce the issue with an audio element on a TYPO3 v13 page. Done means the rendered element includes the controls attribute and the audio player is visible in Chrome and Firefox.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, php
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
90/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.