benjaminkott / benjaminkott/bootstrap_package

obsolete layout.upload code in TCEFORM.tsconfig

Open
#1,432 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
355
Forks
212
Avg merge
1h 4m
Merged PRs (30d)
31

Description

# Bug Report

## Prerequisites

* [x] Can you reproduce the problem on TYPO3 v11.5 LTS
* [ ] Can you reproduce the problem on TYPO3 v12.4 LTS
* [x] Did you [perform a cursory search](https://github.com/issues?q=is%3Aissue+user%3Abenjaminkott+repo%3Abenjaminkott%2Fbootstrap_package)
to see if your bug or enhancement is already reported?

## Description

It seems that there is obsolete configuration code for the `Uploads.html` template in
https://github.com/benjaminkott/bootstrap_package/blob/45333312fceb60fc96a27fd648e8a5547dc230cc/Configuration/TsConfig/Page/TCEFORM.tsconfig#L21

There, two layout options are added and shown in the backend
![grafik](https://github.com/benjaminkott/bootstrap_package/assets/33951787/54085026-282a-4a7a-839a-3a066a0a0246)

but never used in the `Uploads.html` template itself as far as I can see.

Instead, the default field `uploads_type` is used for this purpose

![grafik](https://github.com/benjaminkott/bootstrap_package/assets/33951787/37fe0733-e5b6-4242-9bd6-69ef81c54b60)

We currently use BP12 but the code is also available in BP13 and BP14.

Looking at the history of the `Uploads.html` template it seems that this change happened in BP8 in 2017:
https://github.com/benjaminkott/bootstrap_package/commit/9e9b6c8d0c0405c2ba2957618f8d10a0f1590f1f
Here the template was changed but the configuration was kept.

Maybe the configuration code in TCEFORM is therefore not necessary anymore and can be deleted?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Configuration/TsConfig/Page/TCEFORM.tsconfig at the linked lines, then compare the referenced Uploads.html template and its use of the uploads_type field. Check whether the two layout options are referenced elsewhere in the package; done means obsolete backend options are no longer exposed without affecting the current Uploads.html behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.