benjaminkott / benjaminkott/bootstrap_package

No Frame -> google error

Open
#1,220 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
355
Forks
212
Avg merge
1h 4m
Merged PRs (30d)
31

Description

# Bug Report

## Description

When adding a content element with option "no frame", the output looks like:

```

my content...


```

when checking a site with a content like that with https://pagespeed.web.dev, an error in the seo-chapter occurs:
"links cannot be crawled". See screeshot.

## Steps to Reproduce

1. Add content with option "no frame"
2. Test url with https://pagespeed.web.dev
3. See chapter "SEO"

### Solution

I think replacing the a-tag with an span oder div (in file https://github.com/benjaminkott/bootstrap_package/blob/master/Resources/Private/Layouts/ContentElements/Default.html, line 35) should solve the problem, as we don´t want an link there, but an possible link-target.

### Screenshots

![Zwischenablage01](https://user-images.githubusercontent.com/7531138/204159963-4f0deb42-e89f-4533-8375-2481e8b39ba3.jpg)

## Versions

TYPO3 11
Bootstrap Package 12.0.5

Contributor guide

No contributing guide indexed for this repository

Research direction

Review Resources/Private/Layouts/ContentElements/Default.html at the referenced line and reproduce the issue by adding content with the “no frame” option, then checking the URL with PageSpeed Insights. Confirm that the generated markup no longer produces a crawlable-link error in the SEO report.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.