benjaminkott / benjaminkott/bootstrap_package
css defaults problem with element-header-class in reader-view
- Dominant language
- PHP
- Stars
- 355
- Forks
- 212
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 31
Description
Hi all,
would you maybe consider to change the default for the
[plugin.bootstrap_package_contentelements.header.class]
and [plugin.bootstrap_package_contentelements.subheader.class]
to something that doesn't contain the word "header"?
Why I ask?
the word 'header' makes the element not to be shown in firefox reader, so when you turn on the reader-view of your frontend page, there are all the headlines missing.
[https://github.com/mozilla/readability/blob/master/Readability-readerable.js#L27](url)
[https://videoinu.com/blog/firefox-reader-view-heuristics/](url)
With the best regards,
Sabine
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the defaults for plugin.bootstrap_package_contentelements.header.class and subheader.class, then review the linked Firefox Reader View heuristics. Done means the default classes no longer cause headings to be omitted from Reader View while the frontend headings remain styled and visible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bootstrap, php
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100