bengreenier / bengreenier/overlayed2

Bug: DisplayManagedNode should snap to grid on resize

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
TypeScript
Stars
8
Forks
0
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

The [DisplayManagedNode](https://github.com/bengreenier/overlayed2/blob/master/packages/ux-core/src/lib/layout/display-managed-node.tsx#L100) should snap to the grid for resizing. Today, it only snaps for movement.

**To Reproduce**

Steps to reproduce the behavior:
1. Boot overlayed2
2. Resize the hello world node
3. Note that resizing does not snap to grid

**Expected behavior**

Grid snapping occurs.

**Screenshots**

![no_grid_resize_repro](https://user-images.githubusercontent.com/1167891/69921509-38d8dc00-148a-11ea-8040-a5821429e2d9.gif)

**Configuration (please complete the following information):**

- Version: [`7a547ff`](https://github.com/bengreenier/overlayed2/commit/7a547ff16bc23c7f6a45597b70c48e18d40a6bb5)

Contributor guide

Open the contributing guide

Research direction

Start in packages/ux-core/src/lib/layout/display-managed-node.tsx around line 100, where DisplayManagedNode handles resizing, and compare that path with the existing movement snapping behavior. Reproduce the issue by booting overlayed2 and resizing the hello world node. Done means resizing applies grid snapping as movement already does.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, react, typescript
Domain
desktop, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.