bengreenier / bengreenier/CppFactory

Factory should use unique_ptr

Open
#7 0 comments 0 reactions 1 assignee Claimed by @bengreenier View on GitHub
bug
Dominant language
C++
Stars
12
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Today, the `Factory` class returns `shared_ptr` on `Allocate(...)` calls - it should instead return `unique_ptr` as we do not continue to own the lifetime of the pointer, nor do we maintain a reference to it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.