benchopt / benchopt/benchmark_sqrt_lasso

ENH silence convergence warnings in skglm

Open
#5 0 comments 0 reactions 1 assignee Claimed by @Badr-MOUFAD View on GitHub
Dominant language
Python
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Running the bench I get a lot of these:
```
/home/mathurin/workspace/skglm/skglm/experimental/pdcd_ws.py:155: ConvergenceWarning: PDCD_WS did not converge for tol=1.000e-06 and max_iter=5.
Considering increasing `max_iter` or `tol`.
warnings.warn(
/home/mathurin/workspace/skglm/skglm/experimental/pdcd_ws.py:155: ConvergenceWarning: PDCD_WS did not converge for tol=1.000e-06 and max_iter=1.
Considering increasing `max_iter` or `tol`.
warnings.warn(
/home/mathurin/workspace/skglm/skglm/experimental/pdcd_ws.py:155: ConvergenceWarning: PDCD_WS did not converge for tol=1.000e-06 and max_iter=2.
Considering increasing `max_iter` or `tol`.
```

They should be silenced as in https://github.com/benchopt/benchmark_lasso/blob/main/solvers/sklearn.py#L33 for example

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.