benchopt / benchopt/benchmark_lasso

ENH fit_intercept for sparse design matrices

Open
#109 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
14
Forks
24
PR merge metrics
No merged PRs in 30d

Description

This is a follow-up to PR #94, where fit_intercept support was added for dense data only in some solvers.
For some of these solvers fit_intercept support can be extended to sparse matrices with reasonable effort.
This issue will be used to keep track of this enhancement.

- R-PGD: workaround to [pass a sparse matrix via rpy2](https://stackoverflow.com/questions/48488665/running-glmnet-with-rpy2-on-sparse-design-matrix)
- CD: the code could be directly modified to compensate for X_offset. So, X would not be explicitly centered in order not to break sparsity.
- (...) To be continued: list other solvers that can be adapted and how.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading PR #94 and the solver notes in this issue, especially the CD and R-PGD approaches. Identify which solvers can support fit_intercept with sparse design matrices without breaking sparsity; done means the selected solvers handle this case and have coverage for the new behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.