benchmark-action / benchmark-action/github-action-benchmark

Question: Does this action support alerts on pull requests?

Open
#56 18 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

I've successfully configured this action and everything is running very nicely on the `main` branch. I'm keen to also run this action on pull requests and receive alerts when there are benchmark regressions.

I [updated my action config to run on PRs](https://github.com/ColinEberhardt/assemblyscript-regex/commit/482ee80448f428b36e2460dbe7c759a4e3ace485), however, it fails as follows:

~~~
0s
Run rhysd/github-action-benchmark@v1
with:
tool: benchmarkjs
output-file-path: benchmark/output.txt
comment-on-alert: true
alert-comment-cc-users: @colineberhardt
auto-push: true
name: Benchmark
gh-pages-branch: gh-pages
benchmark-data-dir-path: dev/bench
skip-fetch-gh-pages: false
comment-always: false
save-data-file: true
alert-threshold: 200%
fail-on-alert: false
Error: 'auto-push' is enabled but 'github-token' is not set. Please give API token to push GitHub pages branch to remote
~~~

/see https://github.com/ColinEberhardt/assemblyscript-regex/pull/21

Any ideas?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.