benchmark-action / benchmark-action/github-action-benchmark

Allow a way to use commit comment on fail in the PR gtate

Open
#282 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

Currently, the recommendation is to not use this for PRs. The problem is that the commit comment is only added after it is pushed to main.

This is kind of my way to add it as a gate to CI:
1) PR is submitted
2) BDN is ran
3) If the Mean is out of range it fails it puts a commit comment in the PR
4) PR fails and it isn't added to the charts

For step #3, it would be cool to verify vs a specific commit ID (or maybe most recent one in Main): https://github.com/benchmark-action/github-action-benchmark/issues/281

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.