benchmark-action / benchmark-action/github-action-benchmark

It would be nice if the comparison based action alerts could be done against the commit the PR is being merged into, rather than the most recent prior commit.

Open
#267 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

If I make a change in a PR and it hurts performance, I get a comment from this action alerting me. But, if I then make another change which does not resolve this performance regression, the next comparison the action does will be against the first commit in that PR, not against the base branch I'm trying to merge into, which can present a false view of my performance impact. It would be nice if the comparison could reliably be against the base of the PR rather than the most recent prior commit recorded.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.