benchmark-action / benchmark-action/github-action-benchmark
Question regarding calculation of percentages in the README
Open
documentation
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 184
- PR merge metrics
- No merged PRs in 30d
Description
README states the following:
```
By default, this action marks the result as performance regression when it is worse than the previous
exceeding 200% threshold. For example, if the previous benchmark result was 100 iter/ns and this time
it is 230 iter/ns, it means 230% worse than the previous and an alert will happen. The threshold can
be changed by `alert-threshold` input.
```
- Should this be `ns/iter` and not `iter/ns` as 230 iter/ns is better than 100 iter/ns?
- Also, going from 100 ns/iter to 230 ns/iter is a 130% decrease and not 230% right?
Contributor guide
Assessment
This issue has not been assessed yet.