benchmark-action / benchmark-action/github-action-benchmark

[FR] Set alert threshold per value for more fine-grained control

Open
#183 1 comment 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
1.3k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

We have a workflow which analyzes the output of our product and and sometimes a lower values is better, while other times a higher value is better.
https://github.com/Ultimaker/CuraEngine/blob/33790412b61f33e4f4bfe1af2512f2f621e7aff5/.github/workflows/gcodeanalyzer.yml#L181

Allow for `alert_threshold` to be set per value will give a more fine-grained control
```
{
"name": "Quantity which should not increase",
"value": 12503.752753577128,
"unit": "s"
"alert_treshold": ">110%"
},
{
"name": "Quantity which should not decrease",
"value": 182291,
"unit": "-"
"alert_threshold": "<90%"
},
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.