benchmark-action / benchmark-action/github-action-benchmark

`comment-on-alert` seems to be commenting even if there was no alert

Open
#128 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
184
PR merge metrics
No merged PRs in 30d

Description

My intention, to make PRs less verbose, is to get a benchmark-action comment *only* if there's an alert. That's why I have `comment-always: false` and `comment-on-alert: true` with `alert-threshold: 150%`.

However even though all the ratios were less than 1.5, I got the `github-actions` [comment here](https://github.com/sequentech/strand/pull/35#commitcomment-77799408). This is the [execution that triggered it](https://github.com/sequentech/strand/runs/7210386268?check_suite_focus=true#step:7:1).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.