benawad / benawad/codeponder

Linting Codeponder - TSLint soon to be deprecated

Open
#287 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
282
Forks
45
PR merge metrics
No merged PRs in 30d

Description

## Tslint

tslint is installed but i did not find any configuration file or script to run it

Testing **tslint** with the configuration below produce many linting errors and warnings.

```json
"extends": [
"tslint:recommended",
"tslint-config-standard",
"tslint-react",
"tslint-config-prettier"
]
```

## Eslint + typescript-eslint

> [TSLint Deprecated to Focus Support on typescript-eslint](https://www.infoq.com/news/2019/02/tslint-deprecated-eslint?utm_campaign=infoq_content&utm_source=infoq&utm_medium=feed&utm_term=global)

- [The future of TypeScript on ESLint](https://eslint.org/blog/2019/01/future-typescript-eslint)
- [ESLint Plugin TypeScript](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin)
- [Eslint-config-prettier](https://github.com/prettier/eslint-config-prettier)
- [Configuring ESLint on a TypeScript project](https://javascriptplayground.com/typescript-eslint/)
- [Typescript eslint recommended configuration](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/configs/recommended.json)

Testing **eslint** with the configuration below produce many linting errors and warnings.

```json
module.exports = {
"root": true,

"parser": "@typescript-eslint/parser",

"plugins": ["@typescript-eslint"],

"extends": [
"react-app",
"plugin:@typescript-eslint/recommended",
"prettier",
"prettier/@typescript-eslint"
],

"env": {
"es6": true,
"node": true,
},

"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2018
},

"rules": {
"no-useless-constructor": 0
},

"globals": { }
};
```

I think you should replace tslint with eslint and configure it for react/typescript project with prettier. You can also install vscode extension for Eslint.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files, tests, or entry points are named. Start by locating the installed TSLint configuration and the project scripts, then review the reported ESLint configuration and its linting errors. Done means replacing TSLint with ESLint for the React/TypeScript project, integrating Prettier, and addressing the resulting errors and warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, react, typescript
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.