beeware / beeware/briefcase-windows-app-template
Adjust XML template indentation
- Dominant language
- Batchfile
- Stars
- 11
- Forks
- 25
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 6
Description
#73 introduces some content that is indented like this:
```xml
{% if cookiecutter.install_scope != "perUserOrMachine" %}
{% if cookiecutter.install_options %}
{% else %}
{% endif %}
{% else %}
...
```
@freakboy3742:
> the indentation is intended to reflect the level of indentation in the broader if structure that they're a part of. If we make the indentation of the Jinja elements strictly match the XML elements, then it becomes very difficult to parse the Jinja template clauses.
@mhsmith:
> OK, I see what you mean. But that structure is difficult to perceive, because it has such large blocks of differently-indented XML in between. Maybe we should prioritize readability of the template over "correct" indentation of the output XML, and indent everything by one level inside a Jinja control statement, including the XML.
If this is done, it should also be done in the VisualStudio template.
Contributor guide
Research direction
Review the XML template sections shown in the issue and locate the corresponding VisualStudio template. Compare the Jinja control clauses with the surrounding XML indentation, then verify both templates consistently reflect the intended control structure and still produce valid XML.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100