beetbox / beetbox/pyacoustid

`match` should not be an iterator

Open
#36 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
408
Forks
69
PR merge metrics
No merged PRs in 30d

Description

I think it makes it more complicated to work with the function because in order to subscript it one has to force it into a list first. If each result had to be fetched from the server then it would make a lot of sense to yield them one by one, but since the response is already downloaded and parsed, returning all results at once makes no difference.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Python match function and any tests or callers that cover its return value. Confirm the requested eager-return behavior and update the relevant coverage so done means callers can subscript the result without converting it to a list.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.