core: Refactor or remove existing `mb_albumid` check from core
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 2.1k
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 31
Description
I just noticed we still have a bit of musicbrainz specific logic in the core. Seems a bit inconsistent to me and there might be a better way to resolve this 🤔
https://github.com/beetbox/beets/blob/08081f3c440c3aff2ff66931af645c92edfceb47/beets/autotag/match.py#L422-L442
This needs a bit of a rework in my opinion. I think metadata plugins should handle this on their own or we need to properly define a public interface for registering `_id` fields.
@snejus For visibility.
Contributor guide
Research direction
Start with beets/autotag/match.py at lines 422-442 and trace how the existing mb_albumid check is used. Compare the current metadata-plugin behavior and consider the two directions named in the issue: plugin-owned handling or a public interface for _id fields. Done means the core no longer contains inconsistent MusicBrainz-specific handling under an agreed design.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100