beetbox / beetbox/beets

"never_convert_lossy_files" double negative is confusing

Open
#5,796 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
15.7k
Forks
2.1k
Avg merge
4d 21h
Merged PRs (30d)
31

Description

### Problem

Use of a double negative with a "yes" or "no" answer is confusing for the user.
"never_convert_lossy_files" - "yes" - does it mean: "yes, never convert" or "yes, actually convert"
"never_convert_lossy_files" - "no" - does it mean: "no, never convert" or "no, actually convert"

If you read the documentation, it says that "yes" means "lossy files are always copied".
If there were no double negative, this would be a self-explanatory option: "convert_lossy_files" with a "yes" or "no" answer.

Please consider renaming the option to make it easier to understand.

Contributor guide

Open the contributing guide

Research direction

Start by locating the `never_convert_lossy_files` option and the documentation that explains its yes/no behavior. Trace where the option is defined and consumed, then determine the compatibility and documentation updates needed for a clearer name. Done means the option's behavior is unambiguous and the documentation matches it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.