beefproject / beefproject/beef

Error in ActiveX Command Execution module - urlencoded command

Open
#1,854 2 comments 0 reactions 0 assignees View on GitHub
Good First Issue Medium Module
Dominant language
JavaScript
Stars
11k
Forks
2.4k
Avg merge
1d 1h
Merged PRs (30d)
15

Description

Module ActiveX Command Execution not works with "Initialize and script ActiveX controls not marked as safe for scripting" enabled.
beef-0.5.0.0

#### Environment

> What version/revision of BeEF are you using?

0.5.0.0

> On what versionof Ruby?

ruby 2.5.7p206 (2019-10-01 revision 67816) [x86_64-linux-gnu]

> On what browser?

IE11, with enabled initialize and scptring ...

> On what operating system?

Win10 <- victim
kali linux 2019 with latest updates <- beef framework

#### Configuration

> Are you using a non-default configuration?
no

#### Summary

Error in ActiveX Command Execution module. Only standalone commands execute. Command with space or any special characters not works.

#### Expected Behaviour
execute command on victim:
`cmd.exe /c "echo Hello from BeEF! & pause"`

#### Actual Behaviour

not execute command

#### Additional Information

Resolve propose:
in file
`https://github.com/beefproject/beef/blob/master/modules/exploits/local_host/activex_command_execution/command.js`
text in _cmd_ variable is urlcoded. I changed line 9 to urldecode:
`var cmd = decodeURIComponent(beef.encode.base64.decode('<%= Base64.strict_encode64(@cmd) %>'));`
to resolve issue. Now it works.

Contributor guide

Open the contributing guide

Research direction

Start with modules/exploits/local_host/activex_command_execution/command.js, especially the _cmd_ value and its encoding path. Reproduce in IE11 on Windows 10 with the specified ActiveX setting, using the provided command containing spaces and special characters. Done means standalone and encoded commands execute successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
operating-systems, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.