Bitcoin Wallet Address matches incorrectly
- Dominant language
- Python
- Stars
- 7.3k
- Forks
- 391
- PR merge metrics
- No merged PRs in 30d
Description
```
$ poetry run pywhat "3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F"
Matched on: 3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F
Name: Bitcoin (₿) Wallet Address
Link: https://www.blockchain.com/btc/address/3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F3F
```
The regex catches obvious non Bitcoin addresses. I'm not sure if there's a way to make it stricter as it seems to be pretty specific as is. If it can't be less broad perhaps we should lower the rarity.
Contributor guide
Research direction
Reproduce the false positive with `poetry run pywhat` and the repeated `3F` string, then locate the Bitcoin wallet address regex and its rarity configuration. Done means the obvious non-address input no longer matches, or its rarity is reduced if the pattern cannot be made stricter; add or update coverage for this example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100