beanumber / beanumber/openWAR

make makeSubstitutions() more robust so that batterPos is completely accurate

Open
#5 1 comment 0 reactions 0 assignees View on GitHub
bug enhancement
Dominant language
R
Stars
103
Forks
33
PR merge metrics
No merged PRs in 30d

Description

Sometimes the batterPos cannot be determined by makeSubstitutions(). Usually this is due to a data error. For example, in

```
gid_2013_04_26_pitmlb_slnmlb_1
```

Jeanmar Gomez's playerId is not accurate -- instead Jonathan Sanchez's is listed. In

```
gid_2013_07_10_anamlb_chnmlb_1
```

Brooks Raley's playerId is given as 0.

Not sure how to recover from such errors.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading makeSubstitutions() and reproducing the batterPos failures for gid_2013_04_26_pitmlb_slnmlb_1 and gid_2013_07_10_anamlb_chnmlb_1. Determine how the incorrect playerId and playerId 0 affect substitution handling; done means batterPos is accurate despite these data errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.