bcoin-org / bcoin-org/bsock

socket.io vendor in tests

Open
#5 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Current socket.io vendor in test is probably outdated, it still relies on `new Buffer` so if you run tests it show deprecation warnings. At some point node will probably remove constructors.

I am leaving this as issue right now, so we don't forget to address this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the socket.io vendor used by the tests and inspect the `new Buffer` calls that produce warnings. Identify the appropriate updated vendor source, then run the test suite and confirm the deprecation warnings are gone without changing test behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.