bcoe / bcoe/c8

Recent changes to v8-to-istanbul cause issues for Node 10

Open
#385 0 comments 0 reactions 0 assignees View on GitHub
bug p1
Dominant language
JavaScript
Stars
2.1k
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Recent changes (https://github.com/istanbuljs/v8-to-istanbul/pull/173) are causing issues for Node 10 tests.

Specifically, it's causing branches to no longer be marked as covered in the following code:

```js
#!/usr/bin/env node
'use strict'

if (true) {
console.info('hello world')
} else {
console.info('goodnight moon')
}
```

I would prefer not to rollback since 173 is a great change to the library, but we should dig into this (as it might be breaking Node 10 users).

CC: @glromeo

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.