bcoe / bcoe/c8

could we make --all ignore comments

Open
#182 9 comments 2 reactions 1 assignee Claimed by @j03m View on GitHub
enhancement
Dominant language
JavaScript
Stars
2.1k
Forks
99
PR merge metrics
No merged PRs in 30d

Description

Because our `--all` functionality does not take into account multi-line comments, we end up with a fairly large discrepancy between `nyc` and `c8`'s `--all`, see:

https://github.com/googleapis/nodejs-asset/pull/236

I wonder if we could be clever and detect multiline comments, and drop these from our estimation of `--all`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.