bchavez / bchavez/BugTrap

Windows version detect issue

Open
#5 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
187
Forks
87
PR merge metrics
No merged PRs in 30d

Description

`CSymEngine::GetOsInfo(COsInfo& rOsInfo)` uses deprecated GetVersionEx API. Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2).

We need to find out better way to get windows version, including real major/minor versions, product type, etc.

For a workaround, I just take kernel32.dll version: https://github.com/GoldRenard/BugTrap/commit/ab264288d75990f6f9407ef371187ee919970eee In this way we don't know the real product type, so we can't detect is it server OS or client.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.