The format of the full Chinese name is incorrect.
- Dominant language
- C#
- Stars
- 9.7k
- Forks
- 538
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/bchavez/Bogus/blob/91dc65826175a4d05fe8fda6f29de0578e7350db/Source/Bogus/DataSets/Name.cs#L89
In Chinese full names, the surname comes first, followed by the given name, which is the opposite of English names. For example, the Chinese name 周杰伦 would be written as Jay Chou in English.
The issue in faker-js has been rectified:
https://github.com/faker-js/faker/blob/next/src/locales/zh_CN/person/name.ts
```
export default [
{ value: '{{person.lastName}}{{person.firstName}}', weight: 1 },
];
```
Contributor guide
Research direction
Read Source/Bogus/DataSets/Name.cs around line 89 and inspect how the Chinese full name is assembled. Compare the current order with the linked faker-js locale example, then verify that generated Chinese names place the surname before the given name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100