bchavez / bchavez/Bogus

The person full name locale is not set properly for zh_CN and zh_TW

Open
#479 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
9.7k
Forks
538
PR merge metrics
No merged PRs in 30d

Description

The person name locale is not set properly at [zh_CN](https://github.com/bchavez/Bogus/blob/master/Source/Bogus/data/zh_CN.locale.json) and [zh_TW](https://github.com/bchavez/Bogus/blob/master/Source/Bogus/data/zh_TW.locale.json)

### What locale are you using with Bogus?
zh_CN, zh_TW

### What is the expected behavior?
The proper name value should be
```
"name": [
"#{last_name}#{first_name}"
]
```
And this is consistent with fake.js [locale](https://github.com/faker-js/faker/blob/next/src/locales/zh_CN/person/name.ts)

### What is the actual behavior?

```
"name": [
"#{first_name}#{last_name}"
]
```

Contributor guide

Open the contributing guide

Research direction

Inspect Source/Bogus/data/zh_CN.locale.json and Source/Bogus/data/zh_TW.locale.json, focusing on each locale's person name template. Compare the current ordering with the expected locale behavior and verify that both files use the intended full-name order.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
localization
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.