Dev Task: Review and simplify filtering of actual and forecast rows
Open
4Refinement
- Dominant language
- Python
- Stars
- 65
- Forks
- 11
- Avg merge
- 21h 25m
- Merged PRs (30d)
- 70
Description
We have a bit of a jumble of methods for determining if rows in Morecast are forecasts or actuals. We should review the current implementation and simplify if possible.
Review use and implementation of:
- `isForecastRowPredicate`
- `isForecastRow`
- `getForecastRows`
- `validForecastPredicate`
- `validActualPredicate`
- `rowContainsActual`
Contributor guide
Research direction
Locate the Morecast implementations and call sites for isForecastRowPredicate, isForecastRow, getForecastRows, validForecastPredicate, validActualPredicate, and rowContainsActual. Review how each method identifies forecast and actual rows, then simplify the overlapping logic while preserving the existing filtering behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100