bcgov / bcgov/wps

MoreCast: Refactor weather parameter tab state into an array

Open
#3,509 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
65
Forks
11
Avg merge
21h 25m
Merged PRs (30d)
70

Description

We're running into a race condition when toggling the visibility of weather parameter tabs and the Forecast Summary tab. To reproduce:
1. Launch MoreCast and click the RH tab so both temp and rh are visible.
2. Click the Forecast Summary tab
3. Click the RH tab.

Actual Result: Temp and RH are both visible
Expected Result: Only the RH tab should be visible.

I believe this is happening due to each tab having independent state for managing its visibility and that we can workaround the problem by using a single object to manage the state of all the tabs.

Contributor guide

Open the contributing guide

Research direction

Start by locating the MoreCast weather parameter tabs and Forecast Summary tab state, then reproduce the three-step sequence described in the issue. Trace how visibility is updated when switching tabs. Done means selecting RH after Forecast Summary leaves only RH visible, with the existing behavior covered by an appropriate test if the project has one.

Written by the indexing model from the issue text.

Assessment

Tech stack
react
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.