bcgov / bcgov/rems

filter_ems_data() - filter dates not working as expected

Open
#73 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
20
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Issue found when using filter_ems_data() with specific date constraints - documentation here: https://github.com/bcgov/shinyrems/issues/132

From first glance: I think the issue is that the COLLECTION_START has h:m:s and to_date does not so the default is 00:00:00 which occurs before COLLECTION_START even if the y:m:d is the same

Contributor guide

Open the contributing guide

Research direction

Start by locating filter_ems_data() in the rems package and reviewing the linked documentation in shinyrems issue 132. Reproduce filtering with matching start and end dates, inspect how their time components are handled, and confirm that date constraints include the intended records when the dates are equal.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.