bcgov / bcgov/react-shared-components

Ability to create controlled Input components.

Open
#484 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4
Forks
2
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**
The current version of the Input component doesn't allow you to pass in values to the _value_ attribute, only to the _defaultValue_ attribute. This prevents developers from creating Input components that are controlled by passing in state to the value attribute.

**Describe the solution you'd like**
I would like the option to pass in a prop that gets passed into the value attribute on the input tag. One way I was thinking this could be done is by adding a prop called isControlled that determines whether the value passed into the value prop is passed down to the value or the defaultValue attribute.

If isControlled=true, pass the component's value prop to the value attribute on the input tag.
If isControlled=false, pass the component's value prop to the defaultValue attribute on the input tag. (This is how it currently works).

**Describe alternatives you've considered**
Another alternative would be to add another prop that is passed directly to value. However, this would allow developers to pass values to both value and defaultValue at the same time, which is considered a bad practice in React, and will generate warnings in the console.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.