bcgov / bcgov/range-web

Show Reject Extension button to staff even when all agreement holders have voted yes

Open Beginner friendly
#1,371 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
9
Forks
11
PR merge metrics
No merged PRs in 30d

Description

## Bug

On the range use plan list page (`selectRangeUsePlanPage`), when all agreement holders have voted yes on a forward extension request, the **Reject Extension** button is not displayed to staff (SA) users.

### Current behavior

In `src/components/selectRangeUsePlanPage/ExtensionColumn.js`, `renderExtensionForStaff`, when plan `extensionStatus` is `AWAITING_VOTES` and all votes are received (`extensionReceivedVotes >= extensionRequiredVotes`):

- Staff only sees **Forward Extension For Decision**
- The **Reject Extension** button is missing

The Reject Extension button is only shown while votes are incomplete.

### Expected behavior

Staff should be able to reject the extension even when all agreement holders have voted yes, so **Reject Extension** must be displayed alongside **Forward Extension For Decision** in that state.

### Notes

- Regression introduced by #1182 (hide reject button from staff once all RAH approved) + #1293 (`===` -> `>=`).
- Also present in the `dev` branch equivalent (`ExtensionColumn.tsx`).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/components/selectRangeUsePlanPage/ExtensionColumn.js and inspect renderExtensionForStaff for the AWAITING_VOTES state when extensionReceivedVotes >= extensionRequiredVotes. Compare the equivalent ExtensionColumn.tsx in the dev branch if useful. Done means staff see both Reject Extension and Forward Extension For Decision when all agreement holders have voted yes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
84/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.