bcgov / bcgov/ols-geocoder

Replace provinceCode with the more general subcountryCode

Open
#153 0 comments 0 reactions 0 assignees View on GitHub
enhancement low priority
Dominant language
Java
Stars
17
Forks
7
Avg merge
10h 2m
Merged PRs (30d)
15

Description

subCountryCode replaces provinceCode but is more general. For example, the primary subdivisions of the USA are called states, not provinces and in Switzerland, primary subdivisions are called Cantons).

1. In the source code, change all references from stateProvTerr to subCountryCode.

2. Parameterize the subCountryCode property name to be used in all output schemas and fault messages. The parameter could be called subCountryCodeLabel and maintained in the global parameters list by the geocoder admin app. Initially, valid values are province and state. The suffix "Code" should be automatically appended to subCountryCodeLabel when generating output.

3. For backward compatibility, a GET request should be able to use either provinceCode or subCountryCode to specify a subCountryCode

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.