bcgov / bcgov/nr-theme

Landing Pages to detect theme preferences

Open
#88 3 comments 0 reactions 3 assignees Claimed by @carolinemwood View on GitHub
Dominant language
SCSS
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Proposal: Should landing pages be ~~responsible~~ responsive to device theme preferences or stay in light mode only?

Background: The designers agreed to the Theme Toggle not appearing on the landing page only appearing on the blue header (as to not have to design a toggle that would also have to show up on the white and black backgrounds of the landing pages)

For Team Silva, Jazz implemented code for all of SILVA (including the landing page) to detect device theme settings. So after the Theme Toggle decision to have landing pages be light mode only, SILVA's landing page still detects device theme settings. There is no Theme Toggle on the landing so users do not have to the option to switch the theme.

We asked Chantelle if this was a problem (Sep 7 2023). Chantelle recognized this as a feature, as opposed to a problem. Chantelle wanted Team Silva to survey other teams if they want to adopt this approach for their landing pages.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.