Style Updates Checklist

## ✅ Carbon Component Style Updates Checklist

#### We either need to keep all the rounded corners or get rid of them all - Marina

### Topics that need discussion on July 23rd, 2025:

**Conclusion: we will no make any change for the following items.**
- [ ] Warning icon has a border [🔗 FDS Figma Text](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280426&t=Y7m2vRjQL4ZdPXvd-11) [🔗 FDS Figma Password](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280453&t=Y7m2vRjQL4ZdPXvd-11)
Note: Voted within the design sub-group meeting on July 23rd, 2025:
- Keep with the Carbon default: 5 votes
- Nice to have but not urgent to implement: 1 vote
- Need it now: 0 vote
- Jack's note: The latest Carbon default will include a border for the warning icon. It will be sufficient to follow this new Carbon default.

- [ ] Containers with rounded corners
- [ ] ??? Rounded corners on containers visually affect all components with rounded corners (are these custom-built?) [🔗 FDS sample - Client 4](https://www.figma.com/design/hnHv0cnqYgpBPYYRlwW3or/View-and-edit-client---Client-4?node-id=5872-48196)
- [ ] Should we apply rounded corners to all components, or only round the top corners of input fields (Text Input & Password Input, Number Input, Text Area, Select, Date Picker, Search)?
Note: Voted within the design sub-group meeting on July 23rd, 2025:
- Keep with the Carbon default (straight corners for all): 0 vote
- Keep with what we implemented (only round top corners): 5 votes
- Round all corners: 1 vote
- [ ] Border radius for open panels. Dropdown, select, date picker, time picker, overflow menu. Round corner vs straight corner
Note: Voted within the design sub-group meeting on July 23rd, 2025:
- Keep with the Carbon default (straight corners for all): 4 votes
- Round only bottom corners: 1 vote
- Round all corners: 0 vote

#### Topics that need discussion:
- [ ] Moving forward, do we want to keep with Carbon default, and just apply necessary changes?
- [ ] Decide what are necessary changes (who can decide that)
- [ ] Can we allow existing applications remain unchanged

#### Mismatch between code and Figma:
- Number input: In code, we applied border radius 4px to all corners for the control buttons.
- Dropdown: In code we applied border radius to all corners in the dropdown menu.
- Date picker: In code we set border radius 4px to all corners for calendar picker. In code, we applied border radius 4px to all corners for the previous month and next month button.
- Pagination: In code, we applied border radius 4px to all corners for previous and next buttons and selection buttons.
- UI Shell: In code, we set the background color and height for the header.

#### TODOs:
Developers: done in pr #190
- [x] Typography: Update from BC Sans to BC Sans 2.0 in order to: [🔗 nr-theme backlog](https://github.com/bcgov/nr-theme/issues/124)
- [ ] enable Indigenous characters that align with BC's adoption of legal names with indigenous characters
- [ ] enable 2 new font weights: BC Sans Light and BC Sans Light Italic
- [x] Number input: update the base font
- [x] Update hardcoded color, font in the stylesheet to use tokens
- [x] Provide a documentation for onboarding new applications

Designers:
- [x] Review the latest default Carbon design
- Upon review, the designers see that the latest Carbon defaults have many new or updated components. In order to reduce or avoid the amount work required for an entire overhaul of the FDS design system, the decision is to continue using the FDS components as they are. The designers are to understand that the Figma files they generate based on the FDS design system may not 100% reflect the Carbon web components that are deployed in code because the FDS components may be out of date.
- If a team has the need to adopt and use the newer variants from the latest Carbon default, that team should supply or secure the designer resources to update the respective component on the FDS system. This is meant to happen on an ad hoc basis as opposed to a mandatory and systematic overhaul of the FDS design system.
- [x] Fix the typography naming discrepency between FDS and Carbon
- [ ] https://carbondesignsystem.com/elements/typography/type-sets/
- [x] Data table: update alternating row colours (zebra stripes) in Figma
- [x] Discuss ideas on how to make team-level component customizations more transparent to other teams
- Initial idea is to put new team-level components in the FDS Design System Figma file and clearly name the component, with "[Component] - [Team] [Date]". For example "Button - Alliance 2025"

#### Button
- [x] Border-radius: `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280558&t=33OmhHCjsUk9Arm1-11)

#### Text Input & Password Input (Jack's note: may need to split these up)
- [x] Border-radius: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma Text](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280423&t=Y7m2vRjQL4ZdPXvd-11) [🔗 FDS Figma Password](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280450&t=Y7m2vRjQL4ZdPXvd-11) [🔗 Carbon Text](https://react.carbondesignsystem.com/?path=/story/components-textinput--default)
- Designer scale = 2
- a. FDS brand tone: formal yet friendly, more welcoming than sharp corners.
- b. Gov.bc has rounded corners on text input
- c. It's difficult to even find real world examples of apps/websites without rounded corners
- [ ] Warning icon has a border [🔗 FDS Figma Text](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280426&t=Y7m2vRjQL4ZdPXvd-11) [🔗 FDS Figma Password](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280453&t=Y7m2vRjQL4ZdPXvd-11)

#### Text Area
- [x] Border-radius: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11464-280420&t=Y7m2vRjQL4ZdPXvd-11)

#### Number Input
- [x] Border-radius: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280470&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Base font: `"code-01"` [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280490&t=Y7m2vRjQL4ZdPXvd-11)
- [🔗 BC Sans](https://www2.gov.bc.ca/gov/content/governments/services-for-government/policies-procedures/bc-visual-identity/bc-sans) is a fork of Google's [🔗 Noto font family](https://fonts.google.com/noto). [🔗 Noto Sans Mono](https://fonts.google.com/noto/specimen/Noto+Sans+Mono) is compatible with the BC Sans identity.
- [ ] Warning icon has a border [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280473&t=Y7m2vRjQL4ZdPXvd-11)
- [x] ? In the code, we applied border radius 4px to all corners for the control button.

#### Search
- [x] Border-radius: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280444&t=Y7m2vRjQL4ZdPXvd-11)

#### Checkbox
- [x] Focus state border-radius: `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11463-280555&t=Y7m2vRjQL4ZdPXvd-11)
Note: No code change needed. Checkbox in Figma has no border-radius by default, but in React component, it has. We will not do the style override for it as it already meets our requirements.

#### ~~Radio Button~~

#### Select
- [x] Select field: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11484-280980&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Dropdown menu: `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11484-280980&t=Y7m2vRjQL4ZdPXvd-11). Note: No code change needed, this is by default.

#### Dropdown
- [x] Dropdown field: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11003-405007&t=uJ7fFET36c5hfL4U-11)

#### Date Picker
- [x] Border-radius: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=1880-4443&t=Y7m2vRjQL4ZdPXvd-11)
- [x] ? In code we set border radius 4px to all corners for data picker panel.
- [x] ? In code, we applied border radius 4px to all corners for the previous month and next month button.

#### Time Picker
- [x] Border-radius 4px on left top corner and right top corners, no border-radius in the middle

#### Notification
- [x] Border-radius: `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347172&t=Y7m2vRjQL4ZdPXvd-11)
- [x] New color sets [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347172&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Use `misuse` icon instead of `error-filled` for error notifications [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=17957-11915&t=Y7m2vRjQL4ZdPXvd-11)
Note: this is not doable through scss file, each team will handle it by themselves

#### Tooltip
- [x] Border-radius: `4px` [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11489-326807&t=Y7m2vRjQL4ZdPXvd-11).
Note: No code change needed. Tooltip seems already have a border radius by default, not 4px, but we are okay with it.

#### Modal
- [x] Border-radius: `8px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11489-301220&t=vIILP2g5ZHKC0Cbs-11)
- [ ] Modal content spacing [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11489-301223&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] New footer variants??? [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=410-13792&p=f&t=Y7m2vRjQL4ZdPXvd-11)

#### Tile
- [x] Border-radius: `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11801-334088&t=Y7m2vRjQL4ZdPXvd-11)

#### Data Table
- [x] Header cells: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11509-344415&t=vIILP2g5ZHKC0Cbs-11)
- [x] Row expend icon chevron should have 4px border-radius on all corners when on focus.

#### Pagination
- [x] Border-radius: `0px 0px 4px 4px` (bottom-left and bottom-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11490-296711&t=vIILP2g5ZHKC0Cbs-11)
- [x] Set height of small (2.5rem), medium (3rem) and large (3.5rem) size
- [x] ? In code, we applied border radius 4px to all corners for previous and next buttons and selection buttons.

#### Overflow Menu
- [x] Closed button: border-radius `4px` on all corners [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347742&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Open button: `4px 4px 0px 0px` (top-left and top-right) [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347742&t=Y7m2vRjQL4ZdPXvd-11)
- [x] First menu item: `4px` top-left and top-right [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347742&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Last menu item: `4px` bottom-left and bottom-right [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11939-347742&t=Y7m2vRjQL4ZdPXvd-11)

#### Toggle
Note: this is not widely used, so each team will handle it by themselves
- [ ] Light mode: use **Light Filled** Carbon icon [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=15834-14588&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Dark mode: use **Asleep Filled** Carbon icon [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=15834-14588&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Change text color from text-secondary to text-primary [???🔗 FDS Figma]

#### Left Panel
- [x] List item height: `48px` [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11986-345654&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Left icons use `"link-primary"` color [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11986-345654&t=Y7m2vRjQL4ZdPXvd-11)
- [x] Add a right border for the panel
- [x] Selected item text uses `"primary-text"` color [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11986-345654&t=Y7m2vRjQL4ZdPXvd-11)
Note: this is by Carbon default

#### Right Panel
- [ ] List item height: `48px` [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=12020-343070&t=Y7m2vRjQL4ZdPXvd-11)
Note: this will be handled by each team

#### Slider
- [ ] ??? Rounded top corners for text input [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=1880-6449&t=Y7m2vRjQL4ZdPXvd-11)
Note: this will be handled by the team uses slider

#### Typography

- [x] Label - Change text color from text-secondary to text-primary
This change will apply to Checkbox, Date Picker, Dropdown, Number Input, RadioButton, Select, Slider, Text Input, Password Input, Text Area label

#### Theme / Colour system
- [ ] FDS colour system from 2022 differs from Carbon default [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=11163-269904&t=Y7m2vRjQL4ZdPXvd-11)
Note: we will keep our own color tokens
- [ ] Lime green to Green [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=18570-319186&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Violet to Purple [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=18569-3552&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Pink to Magenta [🔗 FDS Figma](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=18570-3566&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Notification token name change [🔗 FDS Figma Light](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=18572-364&t=Y7m2vRjQL4ZdPXvd-11) [🔗 FDS Figma Dark](https://www.figma.com/design/KDXuYanyOsBCM5vpPmNvGf/FDS-Design-System?node-id=18572-374&t=Y7m2vRjQL4ZdPXvd-11)
- [ ] Add notification color token for "warning-alt" and "info-square" type

Warning state changes ??? (Jack note: Follow 2025 Carbon defaults???)

#### FDS Designer scale of design values
0 - We don't care enough about this change
1 - We don't care about this change for the future, but discarding it may require a lot of re-work for a service in production
2 - We care about this change for the following reasons, but can be convinced to align with default Carbon
3 - This change is to align with UX best practices
4 - This change is to mitigate an accessibility / usability risk
5 - This change represents repeated feedback from users