bcgov / bcgov/ligo-lib

Too Flexible File Permission. Should Have Status Check Before Removing File.

Open
#11 3 comments 0 reactions 1 assignee Claimed by @NovaVic View on GitHub
Dominant language
Python
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

[The permission seems to be too flexible :](https://github.com/bcgov-c/data-linking/blob/develop-2.0/cdi-linking/cdilinker/linker/base.py#L276)

The permission seems to be too flexible. And assumption is we are on some sort of Unix environment. However the latter is not a problem due to containerizing our code.

[Is not it better to check the status/return value of the previous subprocess.call statement before removing the script file?](https://github.com/bcgov-c/data-linking/blob/develop/cdi-linking/cdilinker/linker/base.py#L278)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.