bcgov / bcgov/lcfs

LCFS - Summary compare mode

Open
#3,759 0 comments 0 reactions 0 assignees View on GitHub
Compliance Reporting Medium Story
Dominant language
Python
Stars
6
Forks
6
Avg merge
2d 4h
Merged PRs (30d)
87

Description

Decided against this as different report versions may or may not have an rfr and this could cause issues. better to leave as is

**Description:**
Update the Summary Compare mode so that the Renewable fuel target summary table is also hidden when a supplier has no Renewable Fuel Requirement (RFR). If the table is hidden in the standard Summary view because the supplier has no obligation, it should remain hidden in Compare mode as well. This applies only when all versions of the report (original and any supplemental versions) have no RFR.

**Wireframe:**
N/A

**Purpose and benefit to user:**
Prevents displaying empty or irrelevant summary sections in Compare mode, ensuring the summary view remains clear, accurate, and consistent with the standard Summary display.

**Acceptance Criteria:**
- The Renewable fuel target summary is hidden in Compare mode when it is hidden in the standard Summary view
- The summary remains hidden only if all versions of the report have no Renewable Fuel Requirement
- If any version of the report includes RFR data, the summary is displayed in Compare mode
- Behaviour is consistent for both IDIR and BCeID users

**Development Checklist:**
- Update Compare mode logic to evaluate RFR presence across all report versions
- Reuse or align logic used to hide the summary in the standard Summary view
- Ensure no placeholder text or empty tables are displayed when the summary is hidden
- Add regression tests for reports with and without RFR across original and supplemental versions

**Notes:**
- This change is specific to display logic and does not affect summary calculations
- Confirm behaviour for edge cases where RFR exists only in a returned or superseded report version

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. First resolve the opening decision that says the change was rejected, then trace the Summary and Summary Compare display logic and add regression coverage for original and supplemental versions with and without RFR; done means consistent hiding for both IDIR and BCeID users without empty tables or placeholder text.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.