bcgov / bcgov/foi-flow

Request State - Various Bugs / Tasks

Open
#4,891 1 comment 0 reactions 0 assignees View on GitHub
bug low priority production
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**

When performing QA on #4854 / #4352, several (six total) bugs and missing requirements were identified around request states.

1. When a personal request is moved from 'Intake in Progress' -> 'Peer Review', the request state of 'App Fee Owing' is displayed. When a personal request is moved from 'Intake in Progress' -> 'Peer Review', the request state of 'App Fee Owing' should not be available. Instead, the request state of 'Pending Section 5' should be available.

'App Fee Owing' incorrectly displayed as request state option
![image](https://github.com/bcgov/foi-flow/assets/117312323/8b25c2f7-bb61-47e2-a93e-971eadfe34c8)

Instead, it should have the option of 'Pending Section 5'
![image](https://github.com/bcgov/foi-flow/assets/117312323/de99fbe8-fcb1-4794-a56c-e6ea18632800)

2. When a request is moved to 'Redirect', the request is unassigned from the IAO Assigned To. When a request is moved to 'Redirect', the IAO Assigned To should remain the same value / be retained

Request in 'Intake in Progress', and assigned to a processing team
![image](https://github.com/bcgov/foi-flow/assets/117312323/0b84a55f-e13a-487c-bd78-ca5a05cb083f)

Request changed to 'Redirect', and the IAO Assigned To goes to "Unassigned"
![image](https://github.com/bcgov/foi-flow/assets/117312323/c579b588-f10f-405f-b5f3-798cea001de8)

3. When a user changes a request from 'Pending Section 5' -> 'Peer Review', the user is not able to move the request back to 'Pending Section 5'. If a user moves a request from 'Pending Section 5' -> 'Peer Review', the user should be able to move the request back to 'Pending Section 5', or any state

When a request is moved from 'Pending Section 5' -> 'Peer Review', unable to go back to 'Pending Section 5' or another state
![image](https://github.com/bcgov/foi-flow/assets/117312323/4464acda-fa84-4c69-a65f-293202071bf3)

When a request is moved from 'Pending Section 5' -> 'Peer Review', the following state change options should be available. This follows the 'Peer Review' request state logic developed in #3864
![image](https://github.com/bcgov/foi-flow/assets/117312323/ca70ccd3-ca9f-4bc3-bee1-74bba7bb9f39)

4. Users are unable to go from ‘Open’ back to a previous state. If an error is made moving the request forward, there is no way back.

5. When a request is moved from 'Intake in Progress' -> 'Peer Review', the due date clock should not be active and counting. The due date counter should only be active and counting when the request is moved to 'Open'.

![image](https://github.com/bcgov/foi-flow/assets/117312323/e2112c46-37e4-4eb9-ba87-3eacfeeab45f)

6. When a request is moved to 'Pending Section 5' or 'App Fee Owing' the due date clock begins counting. When a request is in 'Pending Section 5' or 'App Fee Owing', it should be treated as if it's on hold (i.e., the due date clock does not count down).

Days remaining counter should not be active and counting
![image](https://github.com/bcgov/foi-flow/assets/117312323/492c69e2-3cf1-41f6-90a5-06d1a1d8e023)

7. Assuming number 4 above is resolved, when a request is moved from 'App Fee Owing' -> 'Peer Review' or 'Pending Section 5' -> 'Peer Review', while the request is in 'Peer Review', the due date counter should not be active / count down. The due date counter should only be active when the request is moved to 'Open'.

**Link bug to the User Story**

**Impact of this bug**
Describe the impact, i.e. what the impact is, and number of users impacted.

**Chance of Occurring (high/medium/low/very low)**

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**

**Steps to Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
6. Click on '....'
8. Scroll down to '....'
9. See error

**Actual/ observed behaviour/ results**

**Expected behaviour**
A clear and concise description of what you expected to happen. Use the gherking language.

**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.

Contributor guide

Open the contributing guide

Research direction

The issue names no files, tests, or entry points. Start by reproducing the listed request-state transitions in the QA environment and trace where state options, assignment retention, and due-date counting are determined. Done means all seven reported behaviors match the expected transitions and timer behavior, with regression coverage identified for each case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.