bcgov / bcgov/foi-flow

Change state to 'Ready to Publish

Open
#4,869 1 comment 0 reactions 0 assignees View on GitHub
Story
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

* As an IAO analyst
* I want to change a general request to 'Ready to Publish
* so that the Open Information team can queue requests where the OI Review is complete and they are ready to be published on the Open Information website

**Assumptions & Scope**
Only general requests are eligible to go into this state as personal requests are never published on the OI website.

When a general request is put into the 'Publication Review' state, the general request will automatically be populated on OI Team Request Queue; this queue will be handled in another story.

When users shift to this state, they will have an option to go back to the 'Closed' state.

This request state will not count towards the LDD as the request has already been 'Closed'.

This additional states will need a new colour pallette from @JHarrietha-AOT

What is IN scope?
New state for 'Ready to Publish.'

Locking the OI layer so it is no longer editable?

What is NOT in scope?
OI Team Queue
OI redaction layer #3735
New state for 'Publication Review.' #4848

**Acceptance Criteria**

**Scenario 1: Change state to Ready to Publish from Publication Review**
* GIVEN an IAO user is on a GENERAL request in the state 'Publication Review'
* AND they have clicked on the state dropdown menue
* WHEN they select the 'Ready to Publish'
* THEN the state will change to 'Ready to Publish'

**Scenario 2: Change state to Ready to Publish from Peer Review**
* GIVEN an IAO user is on a PERSONAL request in the state 'Peer Review
* AND the previous request state was 'Publication Review'
* AND they have activated the state drop down
* WHEN they select 'Ready to Publish'
* THEN the state will update to 'Ready to Publish'

**Scenario 3: Ready to Publish - General Request - state options**
* GIVEN an IAO user is on a GENERAL request
* AND the state is 'Ready to Publish'
* WHEN they select the state drop down
* THEN they will see the following options: Closed, Peer Review, Publication Review, OI Publication

**Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)**

**Validation Rules? (If yes, list here)**

**Design**
@xxx - please link the Design here

**Definition of Ready**

1. [ ] Is there a well articulated User Story?
2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
3. [ ] If there is a user interface, is there a design?
4. [ ] Does the user story need user research/validation?
5. [ ] Does this User Story needs stakeholder approval?
6. [ ] Design / Solution accepted by Product Owner
7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
9. [ ] Has the story been estimated?

**Definition of Done**

1. [ ] Passes developer unit tests
2. [ ] Passes peer code review
3. [ ] If there's a user interface, passes UX assurance
4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
5. [ ] Confirm Test cases built and succeeding
6. [ ] No regression test failures
7. [ ] Test coverage acceptable by Product Owner
8. [ ] Ticket ready to be merged to master or story branch
9. [ ] Developer to list Config changes/ Update documents and designs
10. [ ] Can be demoed in Sprint Review
11. [ ] Tagged as part of a Release
12. [ ] Feature flagged if required
13. [ ] Change Management activities done?

Contributor guide

Open the contributing guide

Research direction

No implementation files, tests, or entry points are named in the issue. Start by locating the request-state transition and state-dropdown handling, then compare existing review-state tests with the three scenarios; done means the new state and allowed transitions behave as specified without breaking existing request workflows.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.