bcgov / bcgov/foi-flow

Change request state to 'Publication Review'

Open
#4,848 0 comments 0 reactions 0 assignees View on GitHub
Story
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

* As an IAO analyst
* I want to change a general request to 'Publication Review'
* so that the Open Information team can review the request for publication on the Open Information website

**Assumptions & Scope**
Only general requests are eligible to go into this state as personal requests are never published on the OI website.

When a general request is put into the 'Publication Review' state, the general request will automatically be populated on OI Team Request Queue; this queue will be handled in another story.

When users shift to this state, they will have an option to go back to the 'Closed' state.

This request state will not count towards the LDD as the request has already been 'Closed'.

This additional states will need a new colour pallette from @JHarrietha-AOT

What is IN scope?
New state for 'Publication Review.'

What is NOT in scope?
OI Team Queue
OI redaction layer #3735

**Acceptance Criteria**

**Scenario 1: Closed - General Request - State Change Options**
* GIVEN an IAO user is on a GENERAL request in the state 'Closed'
* WHEN they select the state drop down
* THEN they will see the following options: Closed, Response, Ministry Sign-Off, Call for Records, Publication Review

**Scenario 2: Click 'Publication Review'**
* GIVEN an IAO user is on a PERSONAL request in the state 'Intake in Progress'
* AND they have activated the state drop down
* WHEN they select 'Publication Review'
* THEN the state will update to 'Publication Review'

**Scenario 3: Publication Review - General Request - state options**
* GIVEN an IAO user is on a GENERAL request
* AND the state is 'Publication Review
* WHEN they select the state drop down
* THEN they will see the following options: Closed, Peer Review, Ready to Publish

**Scenario 3: Publication Review to Peer Review - General Request - state options**
* GIVEN an IAO user is on a GENERAL request
* AND the state was previously in 'Publication Review'
* WHEN the analyst clicks 'Peer Review'
* THEN they will see the following options in the state dropdown: Closed, Publication Review, Ready to Publish

**Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)**

**Validation Rules? (If yes, list here)**

**Design**
@xxx - please link the Design here

**Definition of Ready**

1. [ ] Is there a well articulated User Story?
2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
3. [ ] If there is a user interface, is there a design?
4. [ ] Does the user story need user research/validation?
5. [ ] Does this User Story needs stakeholder approval?
6. [ ] Design / Solution accepted by Product Owner
7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
9. [ ] Has the story been estimated?

**Definition of Done**

1. [ ] Passes developer unit tests
2. [ ] Passes peer code review
3. [ ] If there's a user interface, passes UX assurance
4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
5. [ ] Confirm Test cases built and succeeding
6. [ ] No regression test failures
7. [ ] Test coverage acceptable by Product Owner
8. [ ] Ticket ready to be merged to master or story branch
9. [ ] Developer to list Config changes/ Update documents and designs
10. [ ] Can be demoed in Sprint Review
11. [ ] Tagged as part of a Release
12. [ ] Feature flagged if required
13. [ ] Change Management activities done?

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating the request state dropdown and the workflow rules for Closed and Publication Review, then compare the implementation with each acceptance scenario, especially the general-versus-personal request contradiction. Done means the specified state options and transitions work and the associated unit and acceptance tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.