'Blank' Code Saved as Default - When Changed to FOIPPA Section, Not Updating Page Flag
- Dominant language
- Python
- Stars
- 8
- Forks
- 2
- Avg merge
- 14h 34m
- Merged PRs (30d)
- 46
Description
**Describe the bug in current situation**
CFD users noted an issue when the 'Blank' code is saved as default. When 'Blank' code is saved as default, and the user updates a redaction with a 'Blank' code to a FOIPPA section, the page flag isn't updating to the correct page flag (i.e., instead of changing to 'Partial Disclosure' or 'Withheld in Full', it stays as 'In Progress').
This is leaving CFD users unable to update the the page flags while they have the 'Blank' code saved as default (which they will have most of the time), and makes it challenging for them to produce a redline or response package (as 'In Progress' is not an acceptable final page flag).
**Link bug to the User Story**
**Impact of this bug**
Medium
**Chance of Occurring (high/medium/low/very low)**
Medium
**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
**Steps to Reproduce**
**For full page redactions ('Withheld in Full' page flag):**
1. Go to a request in the Redaction App
2. Select a page with no redactions or page flags
3. Select to withhold the page in full ('Withheld in Full' page flag), select the 'Blank' code, and click 'Save as Default'

4. The full page redaction will be applied with the 'Blank' code, and the page flag will correctly display as 'In Progress'

5. Next, click the full page redaction and select 'Edit'. Change the FOIPPA section from 'Blank' to an actual FOIPPA section (e.g., s. 22) and click 'Select Code(s)'

8. The FOIPPA correctly updates in the top-left of the full page redaction. But see error, where the page flag remains as 'In Progress', when it should change to 'Withheld in Full'

**For partial redactions ('Partial Disclosure' page flag)**
1. Go to a request in the Redaction App
2. Select a page with no redactions or page flags
3. Apply a redaction box on the page, select the 'Blank' code', and select 'Save as Default'
4. The partial redaction will be applied with the 'Blank' code, and the page flag will correctly display as 'In Progress'
7. Next, click the partial redaction and select 'Edit'
8. Change the FOIPPA section from 'Blank' to an actual FOIPPA section (e.g., s. 22) and click 'Select Code(s)'
9. The FOIPPA correctly updates in the top-left of the full page redaction
11. But see error, where the page flag remains as 'In Progress', when it should change to 'Partial Disclosure'
**Actual/ observed behaviour/ results**
When the 'Blank' code is 'Saved as Default', updating the FOIPPA section on a redaction with a 'Blank' code does not update the page flag accordingly. Instead, the page flag is stuck as 'In Progress'
**Expected behaviour**
A clear and concise description of what you expected to happen. Use the gherking language.
GIVEN a user has the 'Blank' code saved as default
AND a user has applied a full page or partial redaction with the 'Blank' code
WHEN a user edits the redaction and changes the FOIPPA section to any FOIPPA section that is not 'Blank' (i.e., FOIPPA Section != 'Blank')
THEN the FOIPPA section should be updated for the redaction
AND the page flag should update to 'Partial Disclosure' or 'Withheld in Full', based on the redaction with the updated FOIPPA section
**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.
Contributor guide
Research direction
Start by reproducing the full-page and partial-redaction flows in the Redaction App described in the issue, using Blank as the saved default and then changing it to a FOIPPA section. Trace the redaction edit and page-flag update path. Done means the FOIPPA change updates the page flag to Withheld in Full or Partial Disclosure rather than leaving it In Progress.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100