bcgov / bcgov/foi-flow

Consult Page Flag Filter - Stuck When Removing All Consult Page Flags

Open
#4,449 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**
A clear and concise description of what the bug is.

**Link bug to the User Story**

**Impact of this bug**
Describe the impact, i.e. what the impact is, and number of users impacted.

Low - can be resolved with a refresh

**Chance of Occurring (high/medium/low/very low)**
Low

Medium (as users may filter by consult flag, and then change the page flags of the consult pages while this filter is active)

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
Test-Marshal

**Steps to Reproduce**
Steps to reproduce the behavior:
1. Apply the consult page flag / consultee to several pages

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBayttIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--54e6e22257e77d67794c85c053138a1622675539/image.png)

2. Select the Consult page flag filter, and filter the package by the consult/consultees

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbFdtIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--bb8a8b369dc7d8ad99892100ac190591fe17f358/image.png)

3. While the package is filter by the consult/consultee page flags, change the page flags on all pages with the consult page flag to another page flag

Changed all page flags to 'Full Disclosure'
[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbG1tIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--f651396841302b88e25d80280ad54740b8341140/image.png)

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbHFtIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--c719eedb864ad79875f867e03d46860c07699cc5/image.png)

4. Now, try to remove the consult page flag filter, and see error, where you are unable to deselect this filter. This can be fixed by a refresh.

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbHVtIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--308397c24a286939c13b657ef5c01da72c0381d3/image.png)

**Actual/ observed behaviour/ results**

Can't unselect consult page flag filter

**Expected behaviour**

GIVEN a user has the consult page flag filter applied
WHEN the user changes the page flag for all pages flagged with consult/consultee, and no pages remain with the consult/consultee flag
THEN the consult page flag filter will automatically deactivate (when no pages are flagged with a consult/consultee page flag)

**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in the Test-Marshal environment by applying the consult/consultee page flag filter, changing all matching pages to another flag, and attempting to remove the filter. Trace the filter state and page-flag update flow; done means the consult filter automatically deactivates when no matching pages remain, without requiring a refresh.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.