bcgov / bcgov/foi-flow

Request status remains unchanged when a corrupted/error file is used for the state change

Open
#4,419 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**
When a request is moved to "Records Review" state from 'call for Records' then file used to change the state is corrupted/error file, then state change not happening, but it shows the changed state's color at the status

**Link bug to the User Story**

**Impact of this bug**
Describe the impact, i.e. what the impact is, and number of users impacted.

**Chance of Occurring (high/medium/low/very low)**
Medium

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
Test-Marshal

**Steps to Reproduce**
Steps to reproduce the behavior:
1. Go to Ministry login for any request which is in "Call for Records"
2. Change the state to "Records Review"
3. If any error file is used for changing state then ,state change is not happening at all
4. See error

**Actual/ observed behaviour/ results**

**Expected behaviour**
A clear and concise description of what you expected to happen. Use the gherking language.

**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.
[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBZ0dTIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--ae12238ef25f7f2ca4466556c317724b5ab221dc/image.png)

[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBdXFSIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--1c5847f2847ffe9d0392ae1159a5e53d3f80fcd1/Statuschangesclr.png)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the transition in the Test-Marshal environment: use a request in “Call for Records” and attempt to move it to “Records Review” with a corrupted or error file. Trace the request state-change flow and compare the persisted state with the displayed status color; done means the state and status presentation remain consistent when the file is invalid.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.