bcgov / bcgov/foi-flow

Consult Flag - Allow additional flag

Open
#4,403 6 comments 0 reactions 0 assignees View on GitHub
Story
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

* As an IAO user
* I want to be able to always tell when a page was sent for consult
* so that I do not need to retain this information elsewhere

**Assumptions & Scope**
This story comes out of the IAO super user feedback sessions. Users noted that it would be very helpful if the consult flag was retained. Since the consult flag does not contribute to % complete, nor does it allow a sign-off to be downloaded, users have expressed wishes for the consult flag to be retained when a partial disclosure, full disclosure or withheld in full flag also applies.

Users can have the option to manually remove the consult flag if necessary, however, they do not want to lose it for future reference purposes.

What is IN scope?
Updating how flags function with respect to consult flags

What is NOT in scope?

**Acceptance Criteria**

**Scenario 1: Page flagged as consultation - Auto-Flag Behavior - Partial Disclosure**
* GIVEN an IAO user is on a page that is already flagged for a consultation
* WHEN they draw a redaction box in part on the page
* THEN the partial disclosure flag will be set for the page
* AND the consultation flag will be retained and noted with a (c)

**Scenario 2: Page flagged as consultation - Auto-Flag Behavior - Withheld in Full**
* GIVEN an IAO user is on a page that is already flagged for a consultation
* WHEN they mark the page for redaction in full
* THEN the withheld in full flag will be set for the page
* AND the consultation flag will be retained and noted with a (c)

**Scenario 3: Page flagged as consultation - Auto-Flag Behavior - Withheld in Full Flag**
* GIVEN an IAO user is on a page that is already flagged for a consultation
* WHEN they update the flag to withheld in full
* AND select the appropriate redaction mark
* THEN the withheld in full flag will be set for the page
* AND the consultation flag will be retained and noted with a (c)

**Scenario 4: Page flagged as consultation - General Flag Behavior**
* GIVEN an IAO user is on a page that is already flagged for a consultation
* WHEN they select a different flag
* THEN the selected flag will be set for the page
* AND the consultation flag will be retained and noted with a (c)

**Scenario 5: Consult Page Flag - Remove**
* GIVEN an IAO user is on a page that is already flagged for a consultation
* WHEN they select the consult flag again
* THEN the consult flag will be removed
* AND any flag that existed with it will be retained

**Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)**

**Validation Rules? (If yes, list here)**

**Design**
@xxx - please link the Design here

**Definition of Ready**

1. [ ] Is there a well articulated User Story?
2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
3. [ ] If there is a user interface, is there a design?
4. [ ] Does the user story need user research/validation?
5. [ ] Does this User Story needs stakeholder approval?
6. [ ] Design / Solution accepted by Product Owner
7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
9. [ ] Has the story been estimated?

**Definition of Done**

1. [ ] Passes developer unit tests
2. [ ] Passes peer code review
3. [ ] If there's a user interface, passes UX assurance
4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
5. [ ] Confirm Test cases built and succeeding
6. [ ] No regression test failures
7. [ ] Test coverage acceptable by Product Owner
8. [ ] Ticket ready to be merged to master or story branch
9. [ ] Developer to list Config changes/ Update documents and designs
10. [ ] Can be demoed in Sprint Review
11. [ ] Tagged as part of a Release
12. [ ] Feature flagged if required
13. [ ] Change Management activities done?

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by locating the page-flag and redaction behavior, then trace how consult, partial disclosure, withheld in full, and other flags are stored and displayed. Done means the five acceptance scenarios work, including removing consult while retaining any other flag, with unit and regression tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
full-stack
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.