bcgov / bcgov/foi-flow

Unable to apply annotation on page with full page redaction

Open
#4,358 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**

When a page is redacted in full (i.e., the full page has been redacted) using the 'Redact pages' feature, you are unable to add an annotation overtop or within the redaction.

In the image below, the full page has been redacted. When I try to add a 'Note' annotation on the page, I am unable to. The only ways for me to add an annotation is to first delete the full page redaction, apply my annotation, and then add the full page redaction again. Or, I can reduce the size of the full page redaction, add an annotation in the non-redacted space, then move the annotation where it needs to be, then resize the redaction to the full page again.

Full page redacted, unable to add annotation (in this case, a 'Note' annotation) to the page.
[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbGxWIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--9af1c46ae430a97d0b70de2f6086f9d2c9271d92/image.png)

Full page was redacted, but then I shrunk the full page redaction and was able to add my annotation to the unredacted space. Afterwards, I could move it where it needs to be, then resize my redaction back to a full page
[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbHhWIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--af8e38ed1f6ad4ac9d3f1359511ade297527d662/image.png)

Applied my annotation first, then redacted the full page using the 'Redact pages'
[Private Zenhub Image](https://api.zenhub.com/attachedFiles/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBbDFWIiwiZXhwIjpudWxsLCJwdXIiOiJibG9iX2lkIn19--7ce9e216ae5463882a9cce782f161d2e2ed0e1c9/image.png)

This was raised as a minor nuisance for peer reviewers, who may want to leave 'Note' annotation on a full page redaction, which refer to specific text, images or other content underneath the full page redaction (in which case, commenting on the full page redaction would not suffice).

**Link bug to the User Story**

**Impact of this bug**
Describe the impact, i.e. what the impact is, and number of users impacted.
Low

**Chance of Occurring (high/medium/low/very low)**
Low

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
Test-Marshal
See EDU-2023-22226

**Steps to Reproduce**
Steps to reproduce the behavior:
1. Go to a page in the Redaction App
2. Apply a full page redaction
3. Try to add an annotation to the page
4. See error

**Actual/ observed behaviour/ results**

Unable to add annotations when a full page is redacted

**Expected behaviour**
A clear and concise description of what you expected to happen. Use the gherking language.

GIVEN a full page has been redacted
WHEN a user selects an annotation and attempts to add it to the page
THEN the annotation will be overlayed over the full page redaction, and can be applied to the page

**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.

Contributor guide

Open the contributing guide

Research direction

Start in the Redaction App by reproducing the issue through the “Redact pages” feature, then try adding a Note annotation over the full-page redaction. Compare this with adding the annotation before redaction and inspect the annotation and redaction interaction points. Done means annotations can be placed and applied over a full-page redaction while existing redaction behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.