bcgov / bcgov/foi-flow

'Response' -> 'On Hold' - Unable to manually change back to 'Response'

Open
#3,969 1 comment 0 reactions 0 assignees View on GitHub
bug low priority
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**
When a request has an outstanding fee, and it has been changed from 'Response' -> 'On Hold', if an applicant pays outside of the online payment option (e.g., they call and pay over the phone with credit card), the IAO analyst is unable to manually change the request from 'On Hold' -> 'Response'. This occurs regardless of whether the applicant provided and email or not (e.g., sending letter via mail versus sending letter to email).

If an applicant pays via phone or cheque, the IAO analyst can enter the paid amount and payment method, but cannot change the request back to 'Response'. They only have the option to change the request to 'Closed' or 'Call for Records'. This is identical options to when a request is first placed 'On Hold' for fee estimates.

If the applicant pays the outstanding fee using the online payment, the request will automatically go back to 'Response'. It appears we only accounted for the situations where the applicant pays online, and not when they may pay through another method (which requires the IAO analyst to manually enter the paid amount).

When a request goes from 'Response' -> 'On Hold', the IAO analyst should **_always_** have the option to change the request manually back to 'Response'.

**Link bug to the User Story**

**Impact of this bug**
Low

**Chance of Occurring (high/medium/low/very low)**
Low

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**

**Steps to Reproduce**
Steps to reproduce the behavior:
1. Go to a request in 'Response', where there is an outstanding balance to be paid
2. Change the request state from 'Response' -> 'On Hold' (it does not matter if the user is sending the letter to an email or in the mail)
3. On the CFR Form tab, update the 'Amount Paid' to be the full amount, and change the 'Balance Payment Method' to any option that is not "Credit Card - Online"
4. Click on the Request State dropdown, and there is no option to place the request back in 'Response'

**Expected behaviour**
A clear and concise description of what you expected to happen. Use the gherking language.
1. GIVEN an IAO analyst is on a request in 'Response', where there is an outstanding balance to be paid
2. WHEN the IAO analyst changes the request state from 'Response' -> 'On Hold'
3. AND on the CFR Form tab, the IAO analyst updates the 'Amount Paid' to be the full amount, and changes the 'Balance Payment Method' to any option that is not "Credit Card - Online"
4. THEN when the IAO analyst clicks the Request State dropdown, there are the options: 'On Hold', 'Response', 'Closed'.

**Screenshots/ Visual Reference/ Source**
If applicable, add screenshots to help explain your problem. You an use screengrab.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue from a request in Response using the CFR Form tab, then inspect the Request State dropdown after recording a non-online payment. The work is done when the dropdown offers On Hold, Response, and Closed after the full outstanding amount is entered, regardless of payment method.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.